Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VIIRS EDR Active Fires reader for new format and fix fine/coarse 1D swath handling #2210

Merged
merged 3 commits into from Oct 6, 2022

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Sep 28, 2022

Apparently I never tested my last changes to this reader against real files. The instrument and satellite attribute names were not what I expected. This PR fixes them.

See ssec/polar2grid#458

@djhoese djhoese self-assigned this Sep 28, 2022
@djhoese djhoese changed the title Bugix viirsfires sensor Fix VIIRS EDR Active Fires reader for new format and fix fine/coarse 1D swath handling Sep 28, 2022
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #2210 (26b1988) into main (4baae95) will increase coverage by 0.00%.
The diff coverage is 92.85%.

@@           Coverage Diff           @@
##             main    #2210   +/-   ##
=======================================
  Coverage   94.14%   94.14%           
=======================================
  Files         294      294           
  Lines       45103    45108    +5     
=======================================
+ Hits        42461    42466    +5     
  Misses       2642     2642           
Flag Coverage Δ
behaviourtests 4.67% <0.00%> (-0.01%) ⬇️
unittests 94.79% <92.85%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/viirs_edr_active_fires.py 91.93% <50.00%> (ø)
satpy/scene.py 93.37% <100.00%> (+0.01%) ⬆️
.../tests/reader_tests/test_viirs_edr_active_fires.py 100.00% <100.00%> (ø)
satpy/tests/test_scene.py 99.49% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0006%) to 94.743% when pulling 26b1988 on djhoese:bugix-viirsfires-sensor into 4baae95 on pytroll:main.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would like a review from @adybbroe as I think he is already using this reader

@mraspaud
Copy link
Member

mraspaud commented Oct 6, 2022

OK, @adybbroe says we aren't using this, merging

@mraspaud mraspaud merged commit 2e73421 into pytroll:main Oct 6, 2022
@djhoese djhoese deleted the bugix-viirsfires-sensor branch October 6, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants