Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coord renaming for AOD product in 'abi_l2_nc' reader #2216

Merged
merged 3 commits into from
Oct 4, 2022

Conversation

mraspaud
Copy link
Member

This PR fixes the dimension renaming problem from #2215

@mraspaud mraspaud self-assigned this Sep 30, 2022
@mraspaud mraspaud marked this pull request as ready for review September 30, 2022 10:34
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an acceptable workaround for now. I think in the long term and maybe for a more generic CF reader, we should figure out some logic to find all the grid mapping variables, from them find all the axis variables, and from them figure out what dimensions we would like to rename for y/x.

@coveralls
Copy link

coveralls commented Oct 3, 2022

Coverage Status

Coverage increased (+0.003%) to 94.742% when pulling b73eb13 on mraspaud:fix-aod-coord-renaming into 7a30eb8 on pytroll:main.

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #2216 (b73eb13) into main (7a30eb8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2216   +/-   ##
=======================================
  Coverage   94.13%   94.14%           
=======================================
  Files         293      293           
  Lines       45079    45101   +22     
=======================================
+ Hits        42437    42459   +22     
  Misses       2642     2642           
Flag Coverage Δ
behaviourtests 4.68% <0.00%> (-0.01%) ⬇️
unittests 94.79% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/abi_base.py 94.52% <100.00%> (+0.07%) ⬆️
satpy/tests/reader_tests/test_abi_l2_nc.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@djhoese djhoese merged commit b9002de into pytroll:main Oct 4, 2022
@djhoese djhoese changed the title Fix coord renaming for AOD product in abi l2 Fix coord renaming for AOD product in 'abi_l2_nc' reader Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abi l2 nc reader can't handle AOD product
3 participants