New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for compressed FSFiles to HRIT readers #2230
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2230 +/- ##
==========================================
+ Coverage 94.13% 94.21% +0.07%
==========================================
Files 293 295 +2
Lines 45079 45404 +325
==========================================
+ Hits 42437 42778 +341
+ Misses 2642 2626 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
c993c6c
to
c4cd5b0
Compare
I don't know fsspec's internal working. Does this create a local cache for compressed files? |
I'm also new to fsspec, but the following seems to create a permanent cache:
By default caching is disabled. |
Ultimately, these objects provide the read methods, etc. Seems fine (even though I start to be a bit afraid of the layers of IO technology!). My question was related to the performance. I guess it makes sense when developing to use local data, and else you don't want to keep cached copies of the data so a default of no cache seems fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is really all that is needed to make it work then 👍. Looks good to me. I had one inline comment about maybe moving a method for easier code reading.
Add support for compressed FSFiles to HRIT readers, in particular for MTSAT. Usage example: