CF-compliant storage for lon/lat case #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test that datasets are stored in a CF-compliant way when the area has a geodetic (unprojected) CRS, such as a CRS described in latitude and longitude. The test is currently failing due to pytroll#2227.
In the CF lonlat test, make sure the test scene dataset has CRS and x/y coordinates like a real scene.
Add a test for the da2cf encoding when the area has lon/lat coordinates.
When we have a lon/lat grid mapping, write the coordinate units as degrees rather than metre. This commit also includes some refactoring in cf_writer.py.
Codecov Report
@@ Coverage Diff @@
## main #2236 +/- ##
==========================================
+ Coverage 94.12% 94.16% +0.03%
==========================================
Files 294 294
Lines 45189 45279 +90
==========================================
+ Hits 42536 42635 +99
+ Misses 2653 2644 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Refactor the make_fake_scene helper function to reduce the cyclomatic complexity.
Refactor CFWriter._is_projected to reduce the cyclomatic complexity
Fix a bug in make_fake_scene that I introduced while refactoring. Passing area=False will now once again return a scene without areas defined.
djhoese
added
enhancement
djhoese
approved these changes
Oct 14, 2022
Improve the test coverage after refactoring the CF writer, now testing more cases when units are provided but no area.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store datasets with an area using a geodetic CRS (unprojected longitude/latitude) in a CF-compliant way.
Work in progress.