Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VIIRS L1B I-band angle names being inconsistent with VIIRS SDR #2260

Merged
merged 1 commit into from Nov 9, 2022

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Nov 3, 2022

While looking into #2258, it was pointed out that the I-band angle datasets in the viirs_l1b reader don't match the names in the viirs_sdr reader. This PR fixes that as well as refactors some of the yaml_reader.py to follow a top-to-bottom reading strategy (I got annoyed while debugging something).

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #2260 (88dfc5c) into main (05419d7) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2260      +/-   ##
==========================================
+ Coverage   94.12%   94.20%   +0.07%     
==========================================
  Files         295      295              
  Lines       45376    45387      +11     
==========================================
+ Hits        42712    42756      +44     
+ Misses       2664     2631      -33     
Flag Coverage Δ
behaviourtests 4.66% <6.97%> (-0.01%) ⬇️
unittests 94.85% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/yaml_reader.py 97.50% <100.00%> (ø)
satpy/tests/reader_tests/test_viirs_l1b.py 100.00% <100.00%> (+1.06%) ⬆️
satpy/scene.py 93.37% <0.00%> (+0.15%) ⬆️
satpy/resample.py 79.56% <0.00%> (+0.16%) ⬆️
satpy/writers/mitiff.py 92.45% <0.00%> (+0.23%) ⬆️
satpy/readers/viirs_sdr.py 86.94% <0.00%> (+0.26%) ⬆️
satpy/tests/test_config.py 97.18% <0.00%> (+0.40%) ⬆️
satpy/readers/eps_l1b.py 83.62% <0.00%> (+0.43%) ⬆️
satpy/readers/seviri_l1b_native_hdr.py 100.00% <0.00%> (+0.57%) ⬆️
satpy/readers/mviri_l1b_fiduceo_nc.py 100.00% <0.00%> (+0.74%) ⬆️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 94.8% when pulling 88dfc5c on djhoese:bugfix-viirsl1b-angle-names into 05419d7 on pytroll:main.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning up also!

@mraspaud mraspaud merged commit 480fd52 into pytroll:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VIIRS day_microphysics array broadcast error
3 participants