Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiscene blend with weights #2275
Multiscene blend with weights #2275
Changes from 26 commits
1ec54cf
7eba546
a7d5ee7
d4bec06
6a3b52e
d20d4de
51df85e
d32eeeb
4091526
1abfc5a
b28df3f
e262e12
24b9153
695b98d
6627d48
80ff2a0
818b0f1
c2a90d8
248d449
f4b0874
0def84a
3b718ab
505aa24
2d38257
b5adf6a
5e91383
897df3d
0b187dd
c987b5d
933de7b
3c125dc
238c71c
c76e790
8baca79
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the name change here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was because I wanted to distinguish between the composite name and the dataset name, but probably I am not mastering the use/need of the
standard_name
? I can keep thecloudtype
but not sure of the impact.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is no CF standard name then this name only matters for matching enhancements at this point. If you update this standard_name here then an enhancement configuration should be added to match this standard_name (or have one for this specific product name
ct
). Or you can just let it find the default enhancement.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I retverted back using
cloudtype
.