Update AGRI for fill values and cailbration LUTs. #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2276 +/- ##
=======================================
Coverage 94.30% 94.30%
=======================================
Files 306 306
Lines 46039 46043 +4
=======================================
+ Hits 43416 43421 +5
+ Misses 2623 2622 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mraspaud
reviewed
Nov 14, 2022
| lut = self.get(lut_key) | ||
| if lut is None: | ||
| lut_key = f'Calibration/{ds_info.get("lut_key", ds_name)}' |
There was a problem hiding this comment.
Yes, it should be tested - the test_ghi_l1.py file has the cal coefficients stored under Calibration/. Coverage says it's covered too, so that line must be getting called :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Fengyun-4 readers were not correctly dealing with the fill value, which led to deep space pixels being shown as very bright (as the raw data fill value was
65535) instead of being filled.This PR correctly applies the fill value. It also updates the selection of the IR calibration LUT from the file, as in some cases the table was stored under
Calibration/and in other cases it's stored under/.