New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix native resampler not working for some chunk sizes #2291
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2291 +/- ##
==========================================
- Coverage 94.32% 94.31% -0.01%
==========================================
Files 308 308
Lines 46169 46161 -8
==========================================
- Hits 43547 43539 -8
Misses 2622 2622
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for also migrating to pytest!
This PR fixes the issue described in #2245 where a user's chosen chunk size for their data may not be divisible by the aggregation factor, but the overall shape of the array is. There is no reason except avoiding rechunking that this shouldn't work. This PR makes it so rechunking is done if needed.
I also removed the unnecessary rechunking done in the replication step. My hope is that dask will figure out this rechunking automatically and that this won't be needed.
@simonrp84 any testing you can do would be greatly appreciated.
native
resampler fails for some chunk sizes #2245