Replace np.bool by np.bool_

[gerritholl]

np.bool no longer exists in latest numpy, replace with np.bool_.

• Tests added
• Fully documented

[mraspaud]

IIRC, np.bool was an alias for bool, so what is the motivation for switching to np.bool_?

[gerritholl]

IIRC, np.bool was an alias for bool, so what is the motivation for switching to np.bool_?

Considering the context, np.bool_ is probably what was intended. All other types are numpy types.

[gerritholl]

They actually have the same effect:

In [136]: dtype([("C", bool), ("D", np.bool_)])
Out[136]: dtype([('C', '?'), ('D', '?')])

So, why switch? For consistency with the rest of the record array definition.

[codecov]

Codecov Report

Merging #2297 (d2e0bf3) into main (9e62ce7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2297   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files         310      310           
  Lines       46468    46468           
=======================================
  Hits        43843    43843           
  Misses       2625     2625           

Flag	Coverage Δ
behaviourtests	4.60% <0.00%> (ø)
unittests	94.99% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
satpy/readers/seviri_base.py	100.00% <ø> (ø)
satpy/tests/test_dataset.py	100.00% <ø> (ø)
satpy/readers/aapp_mhs_amsub_l1c.py	95.89% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[gerritholl]

The remaining failures are due to libtiff.

https://github.com/pearu/pylibtiff/blob/308bde1b0cedfa15d00ac7e7c3e95a8c39ba2065/libtiff/libtiff_ctypes.py#L644

[coveralls]

Coverage remained the same at 94.943% when pulling d2e0bf3 on gerritholl:np-bool into 9e62ce7 on pytroll:main.

[mraspaud]

LGTM