Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port mitiff writer to use pillow #2315

Merged
merged 14 commits into from Dec 9, 2022

Conversation

TAlonglong
Copy link
Collaborator

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@TAlonglong
Copy link
Collaborator Author

pre-commit.ci autofix

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #2315 (d8fd2a2) into main (f7e056d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2315   +/-   ##
=======================================
  Coverage   94.36%   94.37%           
=======================================
  Files         310      310           
  Lines       46641    46665   +24     
=======================================
+ Hits        44014    44040   +26     
+ Misses       2627     2625    -2     
Flag Coverage Δ
behaviourtests 4.59% <0.00%> (-0.01%) ⬇️
unittests 95.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/tests/writer_tests/test_mitiff.py 99.19% <100.00%> (+0.02%) ⬆️
satpy/writers/mitiff.py 93.33% <100.00%> (+0.88%) ⬆️
satpy/readers/ahi_hsd.py 97.50% <0.00%> (-0.36%) ⬇️
satpy/tests/reader_tests/test_seviri_l1b_nc.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@coveralls
Copy link

coveralls commented Dec 8, 2022

Coverage Status

Coverage increased (+0.007%) to 94.964% when pulling d8fd2a2 on TAlonglong:port-mitiff-writer-to-use-pillow into f7e056d on pytroll:main.

@TAlonglong
Copy link
Collaborator Author

pre-commit.ci autofix

@TAlonglong TAlonglong marked this pull request as ready for review December 9, 2022 09:26
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with the fast conversion to PIL, thanks a lot! I don't have anything to say on the logic, looks good. Some style comments inline

satpy/tests/writer_tests/test_mitiff.py Outdated Show resolved Hide resolved
satpy/tests/writer_tests/test_mitiff.py Outdated Show resolved Hide resolved
satpy/tests/writer_tests/test_mitiff.py Outdated Show resolved Hide resolved
satpy/tests/writer_tests/test_mitiff.py Outdated Show resolved Hide resolved
satpy/tests/writer_tests/test_mitiff.py Outdated Show resolved Hide resolved
satpy/tests/writer_tests/test_mitiff.py Outdated Show resolved Hide resolved
satpy/tests/writer_tests/test_mitiff.py Outdated Show resolved Hide resolved
satpy/tests/writer_tests/test_mitiff.py Outdated Show resolved Hide resolved
satpy/tests/writer_tests/test_mitiff.py Outdated Show resolved Hide resolved
satpy/tests/writer_tests/test_mitiff.py Outdated Show resolved Hide resolved
TAlonglong and others added 6 commits December 9, 2022 12:28
Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
@TAlonglong
Copy link
Collaborator Author

pre-commit.ci autofix

@TAlonglong
Copy link
Collaborator Author

Thanks @mraspaud, I did some updates to reduce duplicated code.

@mraspaud mraspaud added enhancement code enhancements, features, improvements component:writers labels Dec 9, 2022
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mraspaud mraspaud merged commit a109584 into pytroll:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:writers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants