Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scene storage options not being used if no other reader_kwargs are passed #2382

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 6, 2023

The tests added in #2335 weren't robust enough. This fixes the issues identified in #2381.

CC @simonrp84

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #2382 (1f708fd) into main (e33140c) will increase coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #2382      +/-   ##
==========================================
+ Coverage   94.67%   94.69%   +0.01%     
==========================================
  Files         329      329              
  Lines       48691    48693       +2     
==========================================
+ Hits        46097    46108      +11     
+ Misses       2594     2585       -9     
Flag Coverage Δ
behaviourtests 4.42% <0.00%> (+<0.01%) ⬆️
unittests 95.32% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/utils.py 24.56% <0.00%> (-0.15%) ⬇️
satpy/tests/test_scene.py 99.50% <100.00%> (ø)
satpy/tests/test_config.py 97.35% <0.00%> (+0.37%) ⬆️
satpy/tests/reader_tests/test_vii_base_nc.py 100.00% <0.00%> (+1.24%) ⬆️
satpy/tests/reader_tests/test_nwcsaf_msg.py 100.00% <0.00%> (+1.80%) ⬆️
satpy/tests/reader_tests/test_vii_l1b_nc.py 100.00% <0.00%> (+2.81%) ⬆️
satpy/tests/reader_tests/test_vii_l2_nc.py 100.00% <0.00%> (+6.06%) ⬆️
satpy/tests/reader_tests/test_vii_wv_nc.py 100.00% <0.00%> (+6.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@coveralls
Copy link

Coverage Status

Coverage: 95.276% (+0.0002%) from 95.276% when pulling 1f708fd on djhoese:bugfix-storageopts-noreaderkwargs into e33140c on pytroll:main.

@simonrp84
Copy link
Member

I just tested this and the fix is successful! Thanks.

@mraspaud mraspaud added this to the v0.40.0 milestone Feb 7, 2023
@mraspaud mraspaud merged commit 0393daf into pytroll:main Feb 7, 2023
@djhoese djhoese deleted the bugfix-storageopts-noreaderkwargs branch May 17, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote files reading example does not work.
4 participants