Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ABI composite reducerX modifiers #243

Merged
merged 2 commits into from Mar 30, 2018

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Mar 30, 2018

In a previous commit I removed the reducer classes from the AHI python
code, but did not notice they were being used by the ABI composites too.

  • Tests added
  • Tests passed
  • Passes git diff origin/develop **/*py | flake8 --diff

In a previous commit I removed the reducer classes from the AHI python
code, but did not notice they were being used by the ABI composites too.
@djhoese djhoese added this to the v0.9 milestone Mar 30, 2018
@djhoese djhoese self-assigned this Mar 30, 2018
@codecov-io
Copy link

codecov-io commented Mar 30, 2018

Codecov Report

Merging #243 into develop will increase coverage by 0.46%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #243      +/-   ##
===========================================
+ Coverage    60.67%   61.14%   +0.46%     
===========================================
  Files          111      111              
  Lines        13673    13681       +8     
===========================================
+ Hits          8296     8365      +69     
+ Misses        5377     5316      -61
Impacted Files Coverage Δ
satpy/resample.py 37.33% <ø> (ø) ⬆️
satpy/tests/compositor_tests/test_ahi.py 97.05% <100%> (+0.39%) ⬆️
satpy/tests/compositor_tests/test_abi.py 97.14% <100%> (+0.36%) ⬆️
satpy/composites/__init__.py 33.43% <0%> (+8.32%) ⬆️
satpy/composites/cloud_products.py 23.33% <0%> (+23.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd34fb9...3d2146b. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 30, 2018

Coverage Status

Coverage increased (+0.5%) to 61.143% when pulling 3d2146b on davidh-ssec:bugfix-abi-reducers into cd34fb9 on pytroll:develop.

@djhoese djhoese merged commit 48ede2c into pytroll:develop Mar 30, 2018
@djhoese djhoese deleted the bugfix-abi-reducers branch March 30, 2018 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants