Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument name in DayNightComposite example document #2514

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Fix argument name in DayNightComposite example document #2514

merged 1 commit into from
Jun 20, 2023

Conversation

marty-sullivan
Copy link
Contributor

This fixes an argument name in the example documentation for DayNightComposite. This wrong value in the example caused me a headache in figuring out since it did not throw an error but also did not do the expected behavior. I found in the API doc for DayNightComposite that need_alpha=False was supposed to be include_alpha=False.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Yeah, sorry about that. I missed this changed when I asked the contributor to change the kwarg name.

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #2514 (0384cd3) into main (1d37638) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2514   +/-   ##
=======================================
  Coverage   94.85%   94.85%           
=======================================
  Files         337      337           
  Lines       49635    49635           
=======================================
  Hits        47080    47080           
  Misses       2555     2555           
Flag Coverage Δ
behaviourtests 4.41% <ø> (ø)
unittests 95.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5317814646

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.42%

Totals Coverage Status
Change from base Build 5317360458: 0.0%
Covered Lines: 47193
Relevant Lines: 49458

💛 - Coveralls

@djhoese djhoese changed the title fix argument name in DayNightComposite example document Fix argument name in DayNightComposite example document Jun 20, 2023
@djhoese djhoese merged commit f44473f into pytroll:main Jun 20, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants