Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unstable download URL in CI #2527

Merged
merged 3 commits into from Jul 7, 2023
Merged

Update unstable download URL in CI #2527

merged 3 commits into from Jul 7, 2023

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jul 6, 2023

The old URL doesn't seem to have newest pandas and is having some download/HTTPS issues.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@djhoese djhoese requested a review from mraspaud as a code owner July 6, 2023 14:24
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #2527 (f8f6dd6) into main (17006a8) will decrease coverage by 0.01%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##             main    #2527      +/-   ##
==========================================
- Coverage   94.89%   94.89%   -0.01%     
==========================================
  Files         349      349              
  Lines       50842    50859      +17     
==========================================
+ Hits        48248    48263      +15     
- Misses       2594     2596       +2     
Flag Coverage Δ
behaviourtests 4.32% <0.00%> (-0.01%) ⬇️
unittests 95.50% <91.30%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sts/reader_tests/gms/test_gms5_vissr_navigation.py 99.29% <85.71%> (-0.71%) ⬇️
...atpy/tests/reader_tests/gms/test_gms5_vissr_l1b.py 99.66% <88.88%> (-0.34%) ⬇️
satpy/tests/reader_tests/utils.py 100.00% <100.00%> (ø)

@coveralls
Copy link

coveralls commented Jul 6, 2023

Pull Request Test Coverage Report for Build 5487925476

  • 21 of 23 (91.3%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 95.45%

Changes Missing Coverage Covered Lines Changed/Added Lines %
satpy/tests/reader_tests/gms/test_gms5_vissr_l1b.py 8 9 88.89%
satpy/tests/reader_tests/gms/test_gms5_vissr_navigation.py 6 7 85.71%
Totals Coverage Status
Change from base Build 5457841578: -0.002%
Covered Lines: 48376
Relevant Lines: 50682

💛 - Coveralls

@sfinkens
Copy link
Member

sfinkens commented Jul 7, 2023

LGTM, thanks for fixing this!

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix. A couple of comments

satpy/tests/reader_tests/gms/test_gms5_vissr_l1b.py Outdated Show resolved Hide resolved
@djhoese djhoese added component:tests cleanup Code cleanup but otherwise no change in functionality labels Jul 7, 2023
@djhoese djhoese merged commit 8490966 into main Jul 7, 2023
29 of 31 checks passed
@djhoese djhoese deleted the ci-unstable-deps-new-url branch July 7, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup but otherwise no change in functionality component:tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants