Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AMI true_color_reproduction composites to use the hybrid NDVI green #2555

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

simonrp84
Copy link
Member

Currently, the AMI true_color_reproduction composites use the old, deprecated, green method. This PR updates the AMI YAML file to switch to the preferred hybrid NDVI scaling method for computing the green channel.

…I green method rather than the deprecated green metho.
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #2555 (1d26f79) into main (ef4276c) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2555   +/-   ##
=======================================
  Coverage   94.91%   94.91%           
=======================================
  Files         349      349           
  Lines       51157    51157           
=======================================
  Hits        48558    48558           
  Misses       2599     2599           
Flag Coverage Δ
behaviourtests 4.30% <ø> (ø)
unittests 95.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5962719347

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.471%

Totals Coverage Status
Change from base Build 5939673825: 0.0%
Covered Lines: 48671
Relevant Lines: 50980

💛 - Coveralls

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 27211e7 into pytroll:main Sep 7, 2023
19 checks passed
@mraspaud mraspaud added enhancement code enhancements, features, improvements component:compositors labels Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:compositors enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants