-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "A" and "D" checks to ruff config #2641
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2641 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 356 356
Lines 51591 51591
=======================================
Hits 49120 49120
Misses 2471 2471
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 6940911214
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
This PR adds "A" (builtin shadowing) and "D" checks (pydocstyle) to ruff config.
Rule A003 has been set to "ignore" because it would require a significant amount of work to change "id" with something else in the composite objects.
Rule D417 has been set to "ignore" because it wasn't enforced before and it requires deeper understanding of the underlying functions to resolve. I would be nice to have in the future though:
https://docs.astral.sh/ruff/rules/undocumented-param/