Bugfix msg native reader #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam.Dybbroe <adam.dybbroe@smhi.se>
Signed-off-by: Adam.Dybbroe <adam.dybbroe@smhi.se>
stickler-ci
reviewed
Apr 25, 2018
| @@ -33,6 +33,8 @@ | |||
| import numpy as np | |||
|
|
|||
| import xarray as xr | |||
| import dask.array as da | |||
| from satpy import CHUNK_SIZE | |||
There was a problem hiding this comment.
F401 'satpy.CHUNK_SIZE' imported but unused
|
We are not quite ready with this PR yet. Sorry. Will fix the tests first! |
Signed-off-by: Adam.Dybbroe <adam.dybbroe@smhi.se>
Signed-off-by: Adam.Dybbroe <adam.dybbroe@smhi.se>
Codecov Report
@@ Coverage Diff @@
## develop #265 +/- ##
===========================================
- Coverage 63.8% 63.76% -0.05%
===========================================
Files 112 112
Lines 13861 13877 +16
===========================================
+ Hits 8844 8848 +4
- Misses 5017 5029 +12
Continue to review full report at Codecov.
|
added 2 commits
April 25, 2018 13:30
…/satpy into bugfix-msg-native-reader
stickler-ci
reviewed
Apr 25, 2018
satpy/readers/native_msg.py
Outdated
|
|
||
| # The available channels are only known after the header | ||
| # has been read, after that we know what the indices are for each channel | ||
| self.available_channels = dict(zip(CHANNEL_LIST,[False]*len(CHANNEL_LIST))) |
There was a problem hiding this comment.
E231 missing whitespace after ','
Signed-off-by: Adam.Dybbroe <adam.dybbroe@smhi.se>
…ative format Signed-off-by: Adam.Dybbroe <adam.dybbroe@smhi.se>
|
I believe we are ready now, and you can merge when ever it is suitable |
|
We merged develop into this and pushed again. Should be ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the MSG SEVIRI native format reader, and make it Dask compatible.
The changes previously done by Colin was not fully completed. Now, the reader should handle subsetted datasets.
git diff origin/develop **/*py | flake8 --diff