Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unstable version of h5py in CI #2658

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Dec 1, 2023

A while ago I updated the unstable CI to deal with numpy 2.0 changes. The final issue ended up being h5py not being Cython 3 compatible. I have a PR with h5py now that fixes this so this update is trying it out while waiting for that PR to be merged.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@djhoese djhoese added the cleanup Code cleanup but otherwise no change in functionality label Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25786b6) 95.29% compared to head (c85f0a0) 95.32%.
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2658      +/-   ##
==========================================
+ Coverage   95.29%   95.32%   +0.02%     
==========================================
  Files         369      371       +2     
  Lines       52049    52435     +386     
==========================================
+ Hits        49600    49982     +382     
- Misses       2449     2453       +4     
Flag Coverage Δ
behaviourtests 4.16% <ø> (-0.04%) ⬇️
unittests 95.93% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Dec 1, 2023

Pull Request Test Coverage Report for Build 7104213835

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 95.886%

Totals Coverage Status
Change from base Build 7057184699: 0.02%
Covered Lines: 50108
Relevant Lines: 52258

💛 - Coveralls

@djhoese
Copy link
Member Author

djhoese commented Dec 2, 2023

Well the unstable environment builds now...but it fails with a ton of dtype failures with @pnuu's new tests trying to verify 32-bit floats. Note: xarray has what I would consider a bug regarding this so not necessarily an urgent fix unless xarray decides not to fix it and break consistency with numpy.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@djhoese djhoese merged commit fbe017c into pytroll:main Dec 5, 2023
18 of 19 checks passed
@djhoese djhoese deleted the ci-unstable-h5py branch December 5, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup but otherwise no change in functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants