Match all projectables in NDVIHybridGreen.__call__ to avoid coordinate mismatch errors
#2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2694 +/- ##
==========================================
- Coverage 95.39% 95.37% -0.02%
==========================================
Files 371 371
Lines 52697 52704 +7
==========================================
- Hits 50268 50266 -2
- Misses 2429 2438 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
djhoese
reviewed
Dec 15, 2023
Pull Request Test Coverage Report for Build 7224878360
💛 - Coveralls |
djhoese
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, in combination with #2690, fixes #2668.
In the previous implementation, inside the
NDVIHybridGreencompositor, only the projectables related to the NDVI were being matched. The resulting NDVI fraction was then being combined with the remaining projectable in the super__call__, which resulted in failures due to mismatching coordinates.This PR fixes this bug by matching all arrays.