Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new (Eumetrain) FCI RGB composites #2780

Merged
merged 15 commits into from
Apr 17, 2024

Conversation

ameraner
Copy link
Member

@ameraner ameraner commented Apr 15, 2024

This PR adds a series of RGB composites for FCI. In most cases, the new RGBs reuse existing recipes, and will have to be tuned further to account for the specific FCI properties (SRF, resolution, etc).

It adds the composites:

  • night_ir105 for a simple nighttime layer to be used to fill the night-time part in day-only RGBs (see below). This was used for the EUMETSAT FCI first image and commissioning publications.
  • night_ir_alpha, as well as the according night_ir_with_background and night_ir_with_background_hires, as known from e.g. SEVIRI
  • true_color_with_night_ir105, true_color_with_night_ir, true_color_with_night_ir_hires, combining True Color with the night layers above
  • cloud_type, cloud_phase and for each a day-night combination using night_ir105 (cloud_*_with_night_ir105)
  • ir_sandwich , based on colorized_ir_clouds, as well as the day-night combination ir_sandwich_with_night_colorized_ir_clouds. Uses the same recipe as in SEVIRI, with the spectral colormap.
  • fire_temperature, with the classic recipe, plus the variants _38refl with the reflective part of the 3.8µm channel and _rad with the channels in radiance units (here, the stretch limits have been computed by converting the radiance unit of the existing recipe limits)
  • snow, since the according composite in visir.yaml is not being picked up due to the VIS0.8 channel starting only at 0.815, while the dependency looks for 0.8
  • 24h_microphysics, which was missing completely in satpy, and is hence added to visir.yaml, using the standard EUM recipe from https://resources.eumetrain.org/RGBguide/recipes/RGB_recipes.pdf

By doing this, it contributes in several ways to #2670. To close that issue, we still need to sort out a few midlatitude/tropical recipes: since this affects many shared recipes and is not specific to FCI, I would leave that to a different PR.

After this PR, the list of available composites for FCI becomes:

24h_microphysics
airmass
ash
cimss_cloud_type
cimss_cloud_type_raw
cloud_phase
cloud_phase_distinction
cloud_phase_distinction_raw
cloud_phase_raw
cloud_phase_with_night_ir105
cloud_type
cloud_type_with_night_ir105
cloudtop
colorized_ir_clouds
convection
day_essl_colorized_low_level_moisture
day_essl_low_level_moisture
day_microphysics
dust
essl_colorized_low_level_moisture
essl_low_level_moisture
fire_temperature
fire_temperature_38refl
fire_temperature_rad
fog
geo_color
geo_color_background_with_low_clouds
geo_color_high_clouds
geo_color_low_clouds
geo_color_night
green_snow
ir108_3d
ir_cloud_day
ir_sandwich
ir_sandwich_with_night_colorized_ir_clouds
natural_color
natural_color_raw
ndvi_hybrid_green
ndvi_hybrid_green_fully_sunzencorrected
ndvi_hybrid_green_raw
night_fog
night_ir105
night_ir_alpha
night_ir_with_background
night_ir_with_background_hires
night_microphysics
rocket_plume_day
rocket_plume_night
snow
true_color
true_color_fully_sunzencorrected
true_color_raw
true_color_raw_with_corrected_green
true_color_reproduction
true_color_reproduction_corr
true_color_reproduction_uncorr
true_color_with_night_ir
true_color_with_night_ir105
true_color_with_night_ir_hires

A gallery of the new RGBs:
cloud_phase
MTG-I1_FCI_cloud-phase_mtg_fci_fdss_6km_mpl_20231015T153000
cloud_phase_with_night_ir105
MTG-I1_FCI_cloud-phase-with-night-ir105_mtg_fci_fdss_6km_mpl_20231015T153000
cloud_type
MTG-I1_FCI_cloud-type_mtg_fci_fdss_6km_mpl_20231015T153000
cloud_type_with_night_ir105
MTG-I1_FCI_cloud-type-with-night-ir105_mtg_fci_fdss_6km_mpl_20231015T153000
true_color_with_night_ir105
MTG-I1_FCI_true-color-with-night-ir105_mtg_fci_fdss_6km_mpl_20231015T153000
true_color_with_night_ir
platform_FCI_true-color-with-night-ir_mtg_fci_fdss_6km_mpl_20231015T153000
ir_sandwich
MTG-I1_FCI_ir-sandwich_mtg_fci_fdss_6km_mpl_20231015T153000
colorized_ir_clouds
MTG-I1_FCI_colorized-ir-clouds_mtg_fci_fdss_6km_mpl_20231015T153000
ir_sandwich_with_night_colorized_ir_clouds
MTG-I1_FCI_ir-sandwich-with-night-colorized-ir-clouds_mtg_fci_fdss_6km_mpl_20231015T153000
fire_temperature
MTG-I1_FCI_fire-temperature_mtg_fci_fdss_6km_mpl_20231015T153000
fire_temperature_38refl
MTG-I1_FCI_fire-temperature-38refl_mtg_fci_fdss_6km_mpl_20231015T153000
fire_temperature_rad
MTG-I1_FCI_fire-temperature-rad_mtg_fci_fdss_6km_mpl_20231015T153000
snow
MTG-I1_FCI_snow_mtg_fci_fdss_6km_mpl_20231015T153000
24h_microphysics
MTG-I1_FCI_24h-microphysics_mtg_fci_fdss_6km_mpl_20231015T153000

@ameraner ameraner self-assigned this Apr 15, 2024
@ameraner ameraner added the enhancement code enhancements, features, improvements label Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.90%. Comparing base (24109a1) to head (20fd4c1).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2780      +/-   ##
==========================================
- Coverage   95.92%   95.90%   -0.03%     
==========================================
  Files         377      377              
  Lines       53535    53535              
==========================================
- Hits        51356    51345      -11     
- Misses       2179     2190      +11     
Flag Coverage Δ
behaviourtests 4.10% <ø> (-0.01%) ⬇️
unittests 96.00% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonrp84
Copy link
Member

Thanks for adding these! Just a note for now: The example image for the day/night blend with night lights background has the wrong name in the caption I think.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8691804714

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 8626996485: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@ameraner
Copy link
Member Author

Thanks for adding these! Just a note for now: The example image for the day/night blend with night lights background has the wrong name in the caption I think.

Ah, indeed, thanks for noticing - our plotting tool uses the standard_name, which for composites does not always work well.. will need to fix :) (cc @strandgren ). I've added the correct composite name as text in the PR description.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for adding all these composites!

@mraspaud mraspaud merged commit 23af5d4 into pytroll:main Apr 17, 2024
16 of 19 checks passed
@ameraner ameraner deleted the feature_add_fci_composites branch April 17, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants