Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pytest-lazyfixture with pytest-lazy-fixtures #2801

Merged
merged 2 commits into from
May 20, 2024

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented May 17, 2024

This PR replaces the obsolete pytest-lazyfixture with a new variant pytest-lazy-fixtures

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@mraspaud mraspaud added the enhancement code enhancements, features, improvements label May 17, 2024
@mraspaud mraspaud self-assigned this May 17, 2024
@mraspaud mraspaud requested a review from djhoese as a code owner May 17, 2024 06:43
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (f33c3e4) to head (3b9c04e).
Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2801   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         379      379           
  Lines       53888    53888           
=======================================
  Hits        51708    51708           
  Misses       2180     2180           
Flag Coverage Δ
behaviourtests 4.09% <0.00%> (ø)
unittests 96.05% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented May 17, 2024

Pull Request Test Coverage Report for Build 9154652765

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.032%

Totals Coverage Status
Change from base Build 9097460123: 0.0%
Covered Lines: 51580
Relevant Lines: 53711

💛 - Coveralls

@djhoese
Copy link
Member

djhoese commented May 17, 2024

RTD is failing from the missing dependency. There is an rtd environment file somewhere.

@mraspaud
Copy link
Member Author

Sorry for that! Should be fixed now

@djhoese djhoese merged commit 233f698 into pytroll:main May 20, 2024
18 of 19 checks passed
@djhoese
Copy link
Member

djhoese commented May 20, 2024

Thanks!

@mraspaud mraspaud deleted the fix_lazy_fixture branch May 20, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants