-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic calibration coefficient selector #2811
Add generic calibration coefficient selector #2811
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2811 +/- ##
==========================================
+ Coverage 95.91% 95.94% +0.02%
==========================================
Files 366 366
Lines 53504 53613 +109
==========================================
+ Hits 51321 51441 +120
+ Misses 2183 2172 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 9483973148Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9485685926Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9495737646Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9499819988Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! just a couple of minor suggestions
I also renamed "selector" to "picker" |
Pull Request Test Coverage Report for Build 9512668046Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9513296644Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, lgtm!
As a first step towards channel-specific calibration modes (#2599), I added a generic calibration coefficient selector that can be used by all readers.
Example: Three sets of coefficients are available (nominal, meirink, gsics). A user wants to calibrate
The user would provide a wishlist via
reader_kwargs
:Readers would compile a dictionary of coefficients
and could then make queries to get the desired coefficients:
Fallback to nominal coefficients for channel 3:
Let me know what you think!