Add GRIB Reader #283
Merged
Add GRIB Reader #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhoese
added
enhancement
stickler-ci
reviewed
May 4, 2018
| import os | ||
| import sys | ||
| import numpy as np | ||
| import xarray as xr |
There was a problem hiding this comment.
F401 'xarray as xr' imported but unused
| """Test loading all test datasets""" | ||
| pg.open.return_value = FakeGRIB() | ||
| from satpy.readers import load_reader | ||
| import xarray as xr |
There was a problem hiding this comment.
F811 redefinition of unused 'xr' from line 9
Codecov Report
@@ Coverage Diff @@
## develop #283 +/- ##
==========================================
+ Coverage 65.17% 65.4% +0.23%
==========================================
Files 115 117 +2
Lines 14077 14275 +198
==========================================
+ Hits 9174 9337 +163
- Misses 4903 4938 +35
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a very basic/limited GRIB2 reader using pygrib. Once ecCodes from ECMWF is python 3 compatible I will switch to using that. I currently need this for NCEP GFS GRIB files.
TODO:
git diff origin/develop **/*py | flake8 --diff