Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MERSI3 / FY3F support. #2838

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Add MERSI3 / FY3F support. #2838

merged 4 commits into from
Jul 19, 2024

Conversation

simonrp84
Copy link
Member

This PR adds support for the MERSI-3 instrument aboard FY-3F. There's no code changes required, as the existing MERSI-2 code can be used, so only new YAML files are added.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (53b10be) to head (1832175).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2838   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         366      366           
  Lines       53615    53615           
=======================================
  Hits        51446    51446           
  Misses       2169     2169           
Flag Coverage Δ
behaviourtests 4.04% <ø> (ø)
unittests 96.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yukaribbba
Copy link
Contributor

You forgot to change the filetype name from mersi2 to mersi3...

@simonrp84
Copy link
Member Author

You forgot to change the filetype name from mersi2 to mersi3...

Haha, well spotted - fixed now. Thanks @yukaribbba!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10002879545

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.054%

Totals Coverage Status
Change from base Build 9988332527: 0.0%
Covered Lines: 51675
Relevant Lines: 53798

💛 - Coveralls

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is this ready to merge?

@mraspaud
Copy link
Member

Ah, I see it is ready, merging

@mraspaud mraspaud merged commit 144c795 into pytroll:main Jul 19, 2024
19 of 21 checks passed
@mraspaud mraspaud added enhancement code enhancements, features, improvements component:readers labels Jul 19, 2024
@simonrp84 simonrp84 deleted the mersi_fy3f branch July 19, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants