Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nucaps reader for NUCAPS EDR v2 files #326

Merged
merged 3 commits into from Jun 22, 2018

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jun 15, 2018

Includes fix for loading ancillary variables when the ancillary variable is being loaded alongside the dataset that needs it. Also fixes handling of CF standard ancillary variable attributes with multiple variables listed. They were comma-separated, but space separated seems to be the standard: http://cfconventions.org/Data/cf-conventions/cf-conventions-1.6/build/cf-conventions.html#ancillary-data

Additionally this fixes #244 which was mainly worried about the instrument name attribute which changed from 'CrIS' to 'CrIS, ATMS, VIIRS' from v1 to v2 of the NUCAPS EDR files.

Includes fix for loading ancillary variables when the ancillary
variable is being loaded alongside the dataset that needs it.
@djhoese djhoese added this to the v0.9 milestone Jun 15, 2018
@djhoese djhoese self-assigned this Jun 15, 2018
@djhoese djhoese requested a review from mraspaud June 15, 2018 02:09
@coveralls
Copy link

coveralls commented Jun 15, 2018

Coverage Status

Coverage increased (+0.04%) to 68.744% when pulling 7aaa78b on djhoese:bugfix-nucaps-edr-v2 into 377b5ba on pytroll:master.

@codecov
Copy link

codecov bot commented Jun 15, 2018

Codecov Report

Merging #326 into master will increase coverage by 0.03%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   68.73%   68.77%   +0.03%     
==========================================
  Files         121      121              
  Lines       15134    15146      +12     
==========================================
+ Hits        10402    10416      +14     
+ Misses       4732     4730       -2
Impacted Files Coverage Δ
satpy/readers/file_handlers.py 89.79% <ø> (+1.56%) ⬆️
satpy/readers/netcdf_utils.py 95.38% <100%> (+0.22%) ⬆️
satpy/tests/reader_tests/test_nucaps.py 97.9% <100%> (+0.01%) ⬆️
satpy/readers/yaml_reader.py 85.25% <80%> (+0.21%) ⬆️
satpy/readers/nucaps.py 94.14% <88.88%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 377b5ba...7aaa78b. Read the comment docs.

@djhoese djhoese merged commit df20c44 into pytroll:master Jun 22, 2018
@djhoese djhoese deleted the bugfix-nucaps-edr-v2 branch June 22, 2018 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix NUCAPS reader for NUCAPS EDR v2 files
3 participants