Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix freezing of areas before resampling even as strings #348

Merged
merged 2 commits into from Jul 1, 2018

Conversation

mraspaud
Copy link
Member

Dynamic areas passed as strings wouldn't receive the area to freeze on.

  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff

@djhoese
Copy link
Member

djhoese commented Jun 29, 2018

Are there any times where max_area would raise an exception, but we have a static AreaDefinition and therefore wouldn't need it?

@mraspaud
Copy link
Member Author

I haven't encountered this so far

@mraspaud mraspaud self-assigned this Jun 29, 2018
@mraspaud mraspaud added this to the v0.9 milestone Jun 29, 2018
@codecov
Copy link

codecov bot commented Jul 1, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@bc87fed). Click here to learn what that means.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #348   +/-   ##
=========================================
  Coverage          ?   69.68%           
=========================================
  Files             ?      123           
  Lines             ?    15877           
  Branches          ?        0           
=========================================
  Hits              ?    11064           
  Misses            ?     4813           
  Partials          ?        0
Impacted Files Coverage Δ
satpy/resample.py 75.75% <ø> (ø)
satpy/scene.py 84.56% <60%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc87fed...0a790e6. Read the comment docs.

@djhoese djhoese merged commit c72af2a into master Jul 1, 2018
@djhoese djhoese deleted the fix-preresample-freeze branch July 1, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants