Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DayNightCompositor masking imagery incorrectly #378

Merged
merged 1 commit into from Aug 14, 2018

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Jul 31, 2018

This PR fixes the behaviour of DayNightCompositor, which was masking the imagery incorrectly.

@coveralls
Copy link

coveralls commented Jul 31, 2018

Coverage Status

Coverage remained the same at 69.085% when pulling 70218d9 on bugfix-dnc-masking into ade4f95 on master.

@codecov
Copy link

codecov bot commented Jul 31, 2018

Codecov Report

Merging #378 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   69.08%   69.08%           
=======================================
  Files         123      123           
  Lines       15724    15724           
=======================================
  Hits        10863    10863           
  Misses       4861     4861
Impacted Files Coverage Δ
satpy/composites/__init__.py 32.88% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ade4f95...70218d9. Read the comment docs.

@djhoese djhoese changed the title Fix DayNightCompositor Fix DayNightCompositor masking imagery incorrectly Aug 14, 2018
@djhoese djhoese merged commit 0c80f47 into master Aug 14, 2018
@djhoese djhoese deleted the bugfix-dnc-masking branch August 14, 2018 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unmasked data when using DayNightCompositor
3 participants