Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enhancement config loading when yaml file is empty #387

Merged
merged 5 commits into from Aug 14, 2018

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Aug 10, 2018

I was playing around with making my own enhancement configuration files and noticed this small bug. If you have a completely empty enhancement config then you get an exception and nothing happens.

  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff

@djhoese djhoese self-assigned this Aug 10, 2018
@djhoese djhoese added this to the v0.9.1 milestone Aug 10, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 69.05% when pulling fb55ea3 on djhoese:bugfix-empty-enhancement into fbe75c2 on pytroll:master.

@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #387 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
- Coverage   69.05%   69.04%   -0.01%     
==========================================
  Files         123      123              
  Lines       15710    15722      +12     
==========================================
+ Hits        10848    10856       +8     
- Misses       4862     4866       +4
Impacted Files Coverage Δ
satpy/tests/test_writers.py 98.05% <100%> (+0.12%) ⬆️
satpy/writers/__init__.py 75.07% <100%> (+0.22%) ⬆️
satpy/readers/__init__.py 93.33% <0%> (-1.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe75c2...fb55ea3. Read the comment docs.

@djhoese djhoese merged commit 4eeb646 into pytroll:master Aug 14, 2018
@djhoese djhoese deleted the bugfix-empty-enhancement branch August 14, 2018 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants