Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native resampler using SwathDefinition as an AreaDefinition #391

Merged
merged 1 commit into from Aug 15, 2018

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Aug 14, 2018

First fixed by @wroberts4 in #317 but was not cherry-pick-able

If a dataset had a SwathDefinition for an area and also had a 'y' coordinate then the associated if statement was entered when it shouldn't be.

  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff

@djhoese djhoese self-assigned this Aug 14, 2018
@djhoese djhoese added this to the v0.9.1 milestone Aug 14, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.075% when pulling b56fbb3 on djhoese:bugfix-resample-coords into 0c80f47 on pytroll:master.

@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #391 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #391   +/-   ##
=======================================
  Coverage   69.07%   69.07%           
=======================================
  Files         123      123           
  Lines       15722    15722           
=======================================
  Hits        10860    10860           
  Misses       4862     4862
Impacted Files Coverage Δ
satpy/resample.py 75.75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c80f47...b56fbb3. Read the comment docs.

@djhoese djhoese merged commit 00b6a46 into pytroll:master Aug 15, 2018
@djhoese djhoese deleted the bugfix-resample-coords branch August 15, 2018 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants