Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DayNightCompositor not checking inputs areas #395

Merged
merged 2 commits into from Aug 17, 2018

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Aug 17, 2018

This PR fixes an oversight in DayNightCompositor that results in zero-sized composite if the areas of the two unresampled composites do not match.

  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff

@coveralls
Copy link

coveralls commented Aug 17, 2018

Coverage Status

Coverage increased (+0.02%) to 69.053% when pulling 2e45288 on bugfix-DNC-different-shapes into b8afac5 on master.

@codecov
Copy link

codecov bot commented Aug 17, 2018

Codecov Report

Merging #395 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   69.05%   69.05%   -0.01%     
==========================================
  Files         123      123              
  Lines       15739    15740       +1     
==========================================
  Hits        10869    10869              
- Misses       4870     4871       +1
Impacted Files Coverage Δ
satpy/composites/__init__.py 32.78% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8afac5...2e45288. Read the comment docs.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All composites should have a check_areas method. Could you switch to using that instead.

@pnuu
Copy link
Member Author

pnuu commented Aug 17, 2018

Oh. One learns something new every day. I'll update later today.

@djhoese djhoese added this to the v0.9.1 milestone Aug 17, 2018
@djhoese djhoese self-assigned this Aug 17, 2018
@djhoese djhoese changed the title Check that the areas have same shapes Fix DayNightCompositor not checking inputs areas Aug 17, 2018
@djhoese djhoese merged commit 3699da1 into master Aug 17, 2018
@djhoese djhoese deleted the bugfix-DNC-different-shapes branch August 17, 2018 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants