Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'platform_name' metadata in ACSPO and CLAVR-x readers #402

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

katherinekolman
Copy link

@katherinekolman katherinekolman commented Aug 23, 2018

This is a minor fix that changes a variable name in two of the readers to make it consistent across all of them.

  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff

@djhoese djhoese changed the title Fix variable name Fix 'platform_name' metadata in ACSPO and CLAVR-x readers Aug 23, 2018
@djhoese djhoese self-assigned this Aug 23, 2018
@djhoese
Copy link
Member

djhoese commented Aug 23, 2018

When this passes I'll merge it to master and cherry-pick it to the maint/0.9 branch and make a new 0.9 release.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.273% when pulling 6000729 on katherinekolman:master into c799d3a on pytroll:master.

@codecov
Copy link

codecov bot commented Aug 23, 2018

Codecov Report

Merging #402 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #402   +/-   ##
=======================================
  Coverage   69.27%   69.27%           
=======================================
  Files         123      123           
  Lines       15833    15833           
=======================================
  Hits        10968    10968           
  Misses       4865     4865
Impacted Files Coverage Δ
satpy/readers/acspo.py 85.71% <ø> (ø) ⬆️
satpy/readers/clavrx.py 84.14% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c799d3a...6000729. Read the comment docs.

@djhoese djhoese merged commit 1149cd1 into pytroll:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants