Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fast modis lon/lat and angles interpolation #430

Merged
merged 4 commits into from Nov 8, 2018

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Sep 26, 2018

This implements fast Modis lon/lat and angles interpolation based on the second order interpolation described in the CVIIRS format documentation

@mraspaud mraspaud self-assigned this Sep 26, 2018
@djhoese
Copy link
Member

djhoese commented Sep 26, 2018

So have we decided that python-geotiepoints isn't the right package for modis interpolation options?

@mraspaud
Copy link
Member Author

@djhoese nothing is decided, I just threw it here to test out. If I can generalise it, it will probably end up in python geotiepoints

@coveralls
Copy link

coveralls commented Sep 27, 2018

Coverage Status

Coverage increased (+0.7%) to 73.074% when pulling c18ac87 on feature-modis-interpolation into b8671a9 on master.

@codecov
Copy link

codecov bot commented Sep 27, 2018

Codecov Report

Merging #430 into master will increase coverage by 0.37%.
The diff coverage is 4.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
+ Coverage   72.39%   72.76%   +0.37%     
==========================================
  Files         128      134       +6     
  Lines       16918    18115    +1197     
==========================================
+ Hits        12247    13181     +934     
- Misses       4671     4934     +263
Impacted Files Coverage Δ
satpy/readers/hdfeos_l1b.py 15.87% <4.91%> (+1.16%) ⬆️
satpy/readers/nc_goes.py 64.8% <0%> (ø)
satpy/tests/reader_tests/test_nc_goes.py 96.94% <0%> (ø)
satpy/readers/viirs_edr_flood.py 90.24% <0%> (ø)
satpy/tests/reader_tests/test_viirs_flood.py 94.59% <0%> (ø)
satpy/tests/reader_tests/test_nc_slstr.py 93.18% <0%> (ø)
satpy/tests/reader_tests/test_nc_olci.py 93.22% <0%> (ø)
satpy/multiscene.py 80.34% <0%> (+0.02%) ⬆️
satpy/tests/test_readers.py 98.82% <0%> (+0.3%) ⬆️
satpy/readers/__init__.py 95.31% <0%> (+0.48%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8671a9...c18ac87. Read the comment docs.

@mraspaud mraspaud added enhancement code enhancements, features, improvements component:readers labels Oct 9, 2018
@mraspaud mraspaud changed the title [WIP] Implement fast modis lon/lat and angles interpolation Implement fast modis lon/lat and angles interpolation Oct 9, 2018
@mraspaud mraspaud merged commit a633ba2 into master Nov 8, 2018
@mraspaud mraspaud deleted the feature-modis-interpolation branch November 8, 2018 20:08
@mraspaud
Copy link
Member Author

This uses pytroll/python-geotiepoints#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angle interpolation for MODIS data missing
3 participants