Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metop reader #441

Merged
merged 5 commits into from Oct 8, 2018
Merged

Fix metop reader #441

merged 5 commits into from Oct 8, 2018

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Oct 5, 2018

Add python 3 support to the eps l1b reader and provide bounding box reading.

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff
  • Fully documented

@coveralls
Copy link

coveralls commented Oct 5, 2018

Coverage Status

Coverage decreased (-0.1%) to 72.966% when pulling b6cfd9c on fix-metop-reader into 4e1e149 on master.

@codecov
Copy link

codecov bot commented Oct 5, 2018

Codecov Report

Merging #441 into master will decrease coverage by 0.11%.
The diff coverage is 9.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
- Coverage   73.07%   72.96%   -0.12%     
==========================================
  Files         134      134              
  Lines       17662    17689      +27     
==========================================
  Hits        12907    12907              
- Misses       4755     4782      +27
Impacted Files Coverage Δ
satpy/readers/xmlformat.py 17.24% <0%> (ø) ⬆️
satpy/readers/eps_l1b.py 15.85% <9.63%> (-1.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e1e149...b6cfd9c. Read the comment docs.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad there isn't a simple solution for the memmap stuff, but otherwise looks good based on the little I know about this reader. When is get_bounding_box called? What is it used for?

@djhoese
Copy link
Member

djhoese commented Oct 5, 2018

Also the loss of coverage isn't great.

@mraspaud
Copy link
Member Author

mraspaud commented Oct 5, 2018

get_bounding_box is called when instantiating the Scene when the area filter parameter is provided.

About coverage loss, yes it isn't good, but I would like to have real data to test this reader, but since we don't have a way to store and share it to travis effectively, I'd like to pass on that.

@djhoese
Copy link
Member

djhoese commented Oct 5, 2018

Sounds good. I think you could still mock the numpy functions loading the file, but ok.

dtypes.append(np.dtype(the_descr))
fdes.seek(expected_size - grh_dtype.itemsize, 1)

file_dtype = np.dtype([(str(num), the_type) for num, the_type in enumerate(dtypes)])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

F812 list comprehension redefines 'the_type' from line 95

@mraspaud mraspaud self-assigned this Oct 8, 2018
@mraspaud mraspaud added enhancement code enhancements, features, improvements component:readers labels Oct 8, 2018
@mraspaud mraspaud added this to the v0.10 milestone Oct 8, 2018
@mraspaud mraspaud merged commit 2f45b54 into master Oct 8, 2018
@mraspaud mraspaud deleted the fix-metop-reader branch October 8, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants