New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix metop reader #441
Fix metop reader #441
Conversation
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
- Coverage 73.07% 72.96% -0.12%
==========================================
Files 134 134
Lines 17662 17689 +27
==========================================
Hits 12907 12907
- Misses 4755 4782 +27
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too bad there isn't a simple solution for the memmap stuff, but otherwise looks good based on the little I know about this reader. When is get_bounding_box
called? What is it used for?
Also the loss of coverage isn't great. |
About coverage loss, yes it isn't good, but I would like to have real data to test this reader, but since we don't have a way to store and share it to travis effectively, I'd like to pass on that. |
Sounds good. I think you could still mock the numpy functions loading the file, but ok. |
satpy/readers/eps_l1b.py
Outdated
dtypes.append(np.dtype(the_descr)) | ||
fdes.seek(expected_size - grh_dtype.itemsize, 1) | ||
|
||
file_dtype = np.dtype([(str(num), the_type) for num, the_type in enumerate(dtypes)]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
F812 list comprehension redefines 'the_type' from line 95
Add python 3 support to the eps l1b reader and provide bounding box reading.
git diff origin/master **/*py | flake8 --diff