New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow readers to accept pathlib.Path instances as filenames. #451
Conversation
Codecov Report
@@ Coverage Diff @@
## master #451 +/- ##
==========================================
+ Coverage 72.96% 72.97% +<.01%
==========================================
Files 134 134
Lines 17689 17695 +6
==========================================
+ Hits 12907 12913 +6
Misses 4782 4782
Continue to review full report at Codecov.
|
Wow is that really all that is needed? Nice. Would you mind adding a simple unit test? I'm guessing you'll have to add something to check if pathlib is available and skip the test if not (python 2). |
I hope this is enough, I don't know where to test elsewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a small change to how the test is skipped, but otherwise it looks good. One question, since you had to change the fake hdf5 handler to make the test work, does this mean that the base file handler (satpy/readers/file_handlers.py) might also need to be updated? What readers have you tried this with?
Allow readers to accept pathlib.Path instances as filenames.
git diff origin/master **/*py | flake8 --diff