Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SCMI writer not writing fill values properly #456

Merged
merged 2 commits into from Oct 11, 2018

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Oct 10, 2018

@rayg-ssec found out that SCMI files generated did not respect fill values from the original data. I'm not exactly sure how this ever worked.

  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff

@djhoese djhoese self-assigned this Oct 10, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 72.953% when pulling 232fd53 on djhoese:bugfix-scmi-masked into 38fb064 on pytroll:master.

@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #456 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #456   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files         134      134           
  Lines       17695    17695           
=======================================
  Hits        12913    12913           
  Misses       4782     4782
Impacted Files Coverage Δ
satpy/writers/scmi.py 72.18% <100%> (ø) ⬆️
satpy/readers/clavrx.py 91.77% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38fb064...232fd53. Read the comment docs.

@djhoese djhoese merged commit 0aec7a8 into pytroll:master Oct 11, 2018
@djhoese djhoese deleted the bugfix-scmi-masked branch October 11, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants