Improve handling of dependency loading when reader has multiple matches #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhoese
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #474 +/- ##
==========================================
+ Coverage 73.89% 73.95% +0.06%
==========================================
Files 136 136
Lines 17909 17959 +50
==========================================
+ Hits 13234 13282 +48
- Misses 4675 4677 +2
Continue to review full report at Codecov.
|
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address issues brought up related to #458 where
scn.available_composite_names()would result in an AssertionError instead of the proper result. It now shows me only'overview', does that sound right @mraspaud?This PR adds a subclass of KeyError to the DatasetDict key checks called
TooManyResultsto distinguish itself from a regular KeyError where the key doesn't exist. Since it is a subclass of KeyError it shouldn't cause any issues with other code that was specifically catchingKeyError.Note: This is technically a workaround because SatPy isn't smart enough right now to handle datasets with different names but the same exact wavelength.
This PR also sits on top of #458.
git diff origin/master -- "*py" | flake8 --diff