Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more descriptive names to AHI readers AreaDefinition names #496

Merged
merged 1 commit into from Nov 10, 2018

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Nov 9, 2018

The previous names were things like "some_area_name". For users who want to put area names in their filenames ({area.area_id}) this makes the filename extremely ugly and not very useful. I took the information that I could find from the file and put it in the area definition. As far as everyone seems to know AHI HRIT files (himawaricast) these files only come in full disk (FLDK) variants so I hardcoded that name.

  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 74.067% when pulling d4d90b8 on djhoese:bugfix-ahi-area-name into ee6bc3a on pytroll:master.

@codecov
Copy link

codecov bot commented Nov 9, 2018

Codecov Report

Merging #496 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
+ Coverage   74.08%   74.08%   +<.01%     
==========================================
  Files         137      137              
  Lines       18219    18220       +1     
==========================================
+ Hits        13498    13499       +1     
  Misses       4721     4721
Impacted Files Coverage Δ
satpy/readers/ahi_hsd.py 45.6% <100%> (+0.3%) ⬆️
satpy/readers/hrit_jma.py 97.67% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee6bc3a...d4d90b8. Read the comment docs.

@djhoese djhoese merged commit f842a46 into pytroll:master Nov 10, 2018
@djhoese djhoese deleted the bugfix-ahi-area-name branch November 10, 2018 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants