Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on nc_nwcsaf_msg #506

Merged
merged 3 commits into from
Nov 22, 2018
Merged

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Nov 19, 2018

This PR fixes reading the NWCSAF RDT product through using the generic nc_nwcsaf reader instead of the legacy nc_nwcsaf_msg. The latter was removed at the same time.

  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff
  • Fully documented

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 74.445% when pulling 7f99d46 on mraspaud:fix-nwcsaf-rdt into 6fc2669 on pytroll:master.

@coveralls
Copy link

coveralls commented Nov 19, 2018

Coverage Status

Coverage increased (+0.06%) to 74.318% when pulling adf420a on mraspaud:fix-nwcsaf-rdt into 6fc2669 on pytroll:master.

@codecov
Copy link

codecov bot commented Nov 19, 2018

Codecov Report

Merging #506 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
+ Coverage   74.25%   74.44%   +0.18%     
==========================================
  Files         137      136       -1     
  Lines       18218    18149      -69     
==========================================
- Hits        13528    13511      -17     
+ Misses       4690     4638      -52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fc2669...adf420a. Read the comment docs.

@mraspaud mraspaud merged commit 98b56a2 into pytroll:master Nov 22, 2018
@mraspaud mraspaud deleted the fix-nwcsaf-rdt branch November 22, 2018 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants