Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utility functions for generating GeoViews plots #567

Merged
merged 21 commits into from Jan 29, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jan 7, 2019

This is a replacement of #541 after git wreaked havoc on @BENR0's code.

@djhoese djhoese added the enhancement code enhancements, features, improvements label Jan 7, 2019
@djhoese djhoese self-assigned this Jan 7, 2019
satpy/scene.py Outdated Show resolved Hide resolved
satpy/scene.py Outdated Show resolved Hide resolved
satpy/utils.py Outdated Show resolved Hide resolved
@djhoese
Copy link
Member Author

djhoese commented Jan 7, 2019

I made this by taking the master branch and cherry picking individual commits related to the geoviews stuff.

@coveralls
Copy link

coveralls commented Jan 9, 2019

Coverage Status

Coverage increased (+0.1%) to 77.844% when pulling 111a9ee on djhoese:geoviews_cherry into ee1ee7d on pytroll:master.

@djhoese djhoese added this to the v0.12 milestone Jan 9, 2019
@codecov
Copy link

codecov bot commented Jan 19, 2019

Codecov Report

Merging #567 into master will increase coverage by 0.01%.
The diff coverage is 82.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
+ Coverage   77.73%   77.75%   +0.01%     
==========================================
  Files         136      136              
  Lines       19290    19370      +80     
==========================================
+ Hits        14996    15062      +66     
- Misses       4294     4308      +14
Impacted Files Coverage Δ
satpy/tests/test_scene.py 99.34% <100%> (+0.01%) ⬆️
satpy/multiscene.py 75.51% <27.27%> (-2.87%) ⬇️
satpy/scene.py 84.23% <86.04%> (+0.09%) ⬆️
satpy/tests/reader_tests/test_ahi_hsd.py 96.51% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee1ee7d...111a9ee. Read the comment docs.

@djhoese
Copy link
Member Author

djhoese commented Jan 28, 2019

I'm really confused at how coverage went up when there are no tests added. I'll have to add tests later.

@djhoese djhoese merged commit 269117a into pytroll:master Jan 29, 2019
@djhoese djhoese deleted the geoviews_cherry branch January 29, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants