Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Update function declarations to make docs reproducible #579
1 similar comment
@@ Coverage Diff @@ ## master #579 +/- ## ========================================== + Coverage 77.43% 77.44% +0.01% ========================================== Files 136 136 Lines 19143 19153 +10 ========================================== + Hits 14823 14833 +10 Misses 4320 4320
Sorry I wasn't clear: I meant why does the current implementation break the reproducibility of the documentation ?
About readability, I just find that turning eg this:
￼def get_environ_config_dir(default=None): if default is None: ￼ default = PACKAGE_CONFIG_PATH
hurts readability and documentation a bit:
But maybe that's just me :)
While I agree with @mraspaud that the code becomes a little uglier, I think the benefits outweigh the ugliness. It moves the config directory determination to runtime rather than "compile time".
Additionally, this is something (similar) to what I am going to need to do in the future when I start using the
I am OK merging this.
Because it will encode the current build path via that constant (eg.