Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resample reduce_data bug introduced in #582 #600

Merged
merged 1 commit into from Jan 31, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jan 31, 2019

On slack @adybbroe pointed out that resampling was broken in current master. This was caused by some changes in #582 by @pnuu as part of refactoring the code. Bottom line, the source_area variable needs to represent the "reduced" area after reducing has been done.

  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff

@djhoese djhoese added this to the v0.12 milestone Jan 31, 2019
@djhoese djhoese self-assigned this Jan 31, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 78.135% when pulling d467662 on djhoese:bugfix-reduce-data into ea26c9b on pytroll:master.

@codecov
Copy link

codecov bot commented Jan 31, 2019

Codecov Report

Merging #600 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
+ Coverage   78.07%   78.13%   +0.06%     
==========================================
  Files         136      136              
  Lines       19531    19552      +21     
==========================================
+ Hits        15248    15277      +29     
+ Misses       4283     4275       -8
Impacted Files Coverage Δ
satpy/scene.py 88% <100%> (+1.33%) ⬆️
satpy/tests/test_scene.py 99.45% <100%> (+0.01%) ⬆️
satpy/resample.py 88.95% <0%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea26c9b...d467662. Read the comment docs.

@djhoese djhoese merged commit a542665 into pytroll:master Jan 31, 2019
@djhoese djhoese deleted the bugfix-reduce-data branch January 31, 2019 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants