New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enhanced (more natural) version of natural colors composite #606
Add enhanced (more natural) version of natural colors composite #606
Conversation
The composite and compositor names are just placeholders until someone comes up with a better name. Also some help is needed for getting proper channel weights for other instruments than SEVIRI. These weights now default to those shown in https://drmarkh.wordpress.com/2014/07/11/plotting-mcidas-and-sort-of-natural-colour-images/ for SEVIRI. |
Is this ready for merge @pnuu (appart from the conflicts of course) ? |
No, not ready. The channel weights needs tuning, and that's something I don't have patience to do 😁 |
we could merge this and have the weight tuning in another PR ? |
Sure. I'll fix the conflicts. |
thanks |
Congratulations 🎉. DeepCode analyzed your code in 0.103 seconds and we found no issues. Enjoy a moment of no bugs ☀️. 👉 View analysis in DeepCode’s Dashboard |
Codecov Report
@@ Coverage Diff @@
## master #606 +/- ##
==========================================
+ Coverage 89.46% 89.47% +0.01%
==========================================
Files 198 198
Lines 29167 29210 +43
==========================================
+ Hits 26093 26136 +43
Misses 3074 3074
Continue to review full report at Codecov.
|
I see this is merged already but thoughts on a generic weighted compositor? Or maybe an add-on to the generic one which takes a tuple of weights for each band? Also this name may cause a lot of confusion since I think the NOAA imagery teams uses enhanced natural color as the name for one of their composites (a true color). |
This PR adds an enhanced version of natural colors composite that produces more natural colors for the clouds.
git diff origin/master -- "*py" | flake8 --diff