Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enhanced (more natural) version of natural colors composite #606

Merged
merged 6 commits into from Mar 26, 2020

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Feb 5, 2019

This PR adds an enhanced version of natural colors composite that produces more natural colors for the clouds.

  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff

@pnuu pnuu added enhancement code enhancements, features, improvements help wanted component:compositors labels Feb 5, 2019
@pnuu
Copy link
Member Author

pnuu commented Feb 5, 2019

The composite and compositor names are just placeholders until someone comes up with a better name.

Also some help is needed for getting proper channel weights for other instruments than SEVIRI. These weights now default to those shown in https://drmarkh.wordpress.com/2014/07/11/plotting-mcidas-and-sort-of-natural-colour-images/ for SEVIRI.

@mraspaud
Copy link
Member

Is this ready for merge @pnuu (appart from the conflicts of course) ?

@mraspaud mraspaud added this to the v0.21.0 milestone Mar 26, 2020
@pnuu
Copy link
Member Author

pnuu commented Mar 26, 2020

No, not ready. The channel weights needs tuning, and that's something I don't have patience to do 😁

@mraspaud
Copy link
Member

we could merge this and have the weight tuning in another PR ?

@pnuu
Copy link
Member Author

pnuu commented Mar 26, 2020

Sure. I'll fix the conflicts.

@mraspaud
Copy link
Member

thanks

@ghost
Copy link

ghost commented Mar 26, 2020

Congratulations 🎉. DeepCode analyzed your code in 0.103 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 89.473% when pulling 9514b24 on pnuu:feature-enhanced-natural-colors into 6c11402 on pytroll:master.

@coveralls
Copy link

coveralls commented Mar 26, 2020

Coverage Status

Coverage increased (+0.02%) to 89.476% when pulling 9514b24 on pnuu:feature-enhanced-natural-colors into 6c11402 on pytroll:master.

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #606 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
+ Coverage   89.46%   89.47%   +0.01%     
==========================================
  Files         198      198              
  Lines       29167    29210      +43     
==========================================
+ Hits        26093    26136      +43     
  Misses       3074     3074              
Impacted Files Coverage Δ
satpy/tests/compositor_tests/__init__.py 100.00% <ø> (ø)
satpy/composites/__init__.py 78.76% <100.00%> (+0.39%) ⬆️
satpy/tests/test_composites.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c11402...9514b24. Read the comment docs.

@pnuu
Copy link
Member Author

pnuu commented Mar 26, 2020

The natural_enh composite added in this PR:
natural_enh_scaled

The already existing natural_color composite:
natural_color_scaled

@mraspaud mraspaud merged commit 8853aac into pytroll:master Mar 26, 2020
@djhoese
Copy link
Member

djhoese commented Mar 26, 2020

I see this is merged already but thoughts on a generic weighted compositor? Or maybe an add-on to the generic one which takes a tuple of weights for each band? Also this name may cause a lot of confusion since I think the NOAA imagery teams uses enhanced natural color as the name for one of their composites (a true color).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:compositors enhancement code enhancements, features, improvements help wanted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants