Fix geotiff writer being unimportable if gdal isn't installed #616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The geotiff writer is deprecating its use of the 'gdal' python library. It is recommended (and has been for a long time) that
trollimage
is used withrasterio
. Therasterio
library only uses the Cgdal
library and not the python library. On some environments (conda) it is possible to haverasterio
and not python gdal. The geotiff writer currently imports gdal regardless of rasterio existing so in this case you would be unable to use the geotiff writer at all even though you had all the necessary dependencies. This PR fixes that and raises an error if neither rasterio or gdal is importable.git diff origin/master -- "*py" | flake8 --diff