Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNB satellite angles (DNB_SENZ, DNB_SENA) to VIIRS SDR reader #627

Merged
merged 1 commit into from Feb 25, 2019
Merged

Add DNB satellite angles (DNB_SENZ, DNB_SENA) to VIIRS SDR reader #627

merged 1 commit into from Feb 25, 2019

Conversation

simonrp84
Copy link
Member

Currently, the VIIRS SDR reader does not load the satellite zenith and azimuth angles from the geolocation file. This PR allows those datasets to be read if required (as is already done for I and M band data).

@coveralls
Copy link

coveralls commented Feb 21, 2019

Coverage Status

Coverage increased (+0.02%) to 78.292% when pulling 0b6f83b on simonrp84:master into 2a49bf6 on pytroll:master.

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #627 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
+ Coverage   78.27%   78.29%   +0.02%     
==========================================
  Files         136      136              
  Lines       19725    19725              
==========================================
+ Hits        15439    15443       +4     
+ Misses       4286     4282       -4
Impacted Files Coverage Δ
satpy/readers/__init__.py 95.12% <0%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a49bf6...48be626. Read the comment docs.

@djhoese djhoese added enhancement code enhancements, features, improvements component:readers labels Feb 21, 2019
@djhoese djhoese added this to the v0.13 milestone Feb 21, 2019
@djhoese djhoese changed the title Update to viirs reader to also load satellite angles for DNB datasets Add DNB satellite angles (DNB_SENZ, DNB_SENA) to VIIRS SDR reader Feb 21, 2019
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simonrp84
Copy link
Member Author

Problem with the inclusion of two commits in one should be resolved, this should only include the VIIRS changes.

@mraspaud mraspaud merged commit ef5dc2c into pytroll:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants