Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seviri_l1b_hrit prologue/epilogue readers #660

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

sfinkens
Copy link
Member

@sfinkens sfinkens commented Mar 14, 2019

Didn't accept the extra calibration keyword arguments

  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff

Didn't accept the extra calibration keyword arguments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 78.536% when pulling 4070876 on sfinkens:fix-seviri-hrit-ext-calib into 8eea7cf on pytroll:master.

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #660 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   78.53%   78.55%   +0.01%     
==========================================
  Files         138      138              
  Lines       20073    20089      +16     
==========================================
+ Hits        15765    15781      +16     
  Misses       4308     4308
Impacted Files Coverage Δ
satpy/readers/seviri_l1b_hrit.py 64.36% <100%> (ø) ⬆️
satpy/tests/reader_tests/test_seviri_l1b_hrit.py 97.05% <100%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eea7cf...4070876. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 70cdacb into pytroll:master Mar 14, 2019
@mraspaud mraspaud added this to the v0.13 milestone Mar 14, 2019
@sfinkens sfinkens deleted the fix-seviri-hrit-ext-calib branch March 15, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants