Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scene.crop with RGBs and multidimensional data #664

Merged
merged 1 commit into from Mar 15, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Mar 15, 2019

Geo2Grid user noticed an odd behavior when making AHI RGBs and cropping to a lat/lon bbox. After investigating I discovered that Scene.crop is broken for any DataArrays with multiple dimensions where y and x are not the first dimensions.

  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 78.662% when pulling 8e471fe on djhoese:bugfix-crop-rgbs into 757a052 on pytroll:master.

@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #664 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #664      +/-   ##
==========================================
+ Coverage   78.63%   78.66%   +0.02%     
==========================================
  Files         138      138              
  Lines       20332    20353      +21     
==========================================
+ Hits        15989    16011      +22     
+ Misses       4343     4342       -1
Impacted Files Coverage Δ
satpy/scene.py 89.13% <100%> (+0.18%) ⬆️
satpy/tests/test_scene.py 99.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 757a052...8e471fe. Read the comment docs.

@djhoese djhoese added this to the v0.13 milestone Mar 15, 2019
@djhoese djhoese merged commit 945dbb3 into pytroll:master Mar 15, 2019
@djhoese djhoese deleted the bugfix-crop-rgbs branch March 15, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants