Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offset correction in seviri_l1b_hrit #688

Merged
merged 2 commits into from Apr 2, 2019

Conversation

sfinkens
Copy link
Member

@sfinkens sfinkens commented Apr 1, 2019

Fix the geo-reference offset correction in seviri_l1b_hrit: Area extent must be shifted in S-E direction (currently N-E). See https://github.com/pytroll/satpy/wiki/SEVIRI-georeferencing-offset-correction for details.

  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff
  • Fully documented

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 79.009% when pulling 6c47241 on sfinkens:fix-seviri-offset-correction into c95603f on pytroll:master.

@coveralls
Copy link

coveralls commented Apr 1, 2019

Coverage Status

Coverage increased (+0.04%) to 79.009% when pulling a7efc06 on sfinkens:fix-seviri-offset-correction into c95603f on pytroll:master.

@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #688 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #688      +/-   ##
=========================================
+ Coverage   78.99%     79%   +0.01%     
=========================================
  Files         138     138              
  Lines       20592   20595       +3     
=========================================
+ Hits        16267   16272       +5     
+ Misses       4325    4323       -2
Impacted Files Coverage Δ
satpy/readers/seviri_l1b_hrit.py 77.91% <100%> (+1.25%) ⬆️
satpy/tests/reader_tests/test_seviri_l1b_hrit.py 97.9% <100%> (+0.03%) ⬆️
satpy/scene.py 89.71% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c95603f...a7efc06. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 6cb5656 into pytroll:master Apr 2, 2019
@sfinkens sfinkens deleted the fix-seviri-offset-correction branch April 5, 2019 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants