New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing docstring for to_image #703
Add missing docstring for to_image #703
Conversation
Add missing docstring for the ``to_image`` function in the ``satpy.writers.__init__`` module.
Codecov Report
@@ Coverage Diff @@
## master #703 +/- ##
=======================================
Coverage 79.68% 79.68%
=======================================
Files 145 145
Lines 21191 21191
=======================================
Hits 16886 16886
Misses 4305 4305
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mraspaud isn't this method now obsolete since I think the XRImage
class itself does all of this? Or does it not squeeze? Is the squeeze
needed?
Squeeze might be needed to remove some unneeded, but tbh I don't remember |
This is the current stuff that XRImage does to "correct" for various dimension schemes: https://github.com/pytroll/trollimage/blob/master/trollimage/xrimage.py#L189-L220 It doesn't do any squeezing, but I'm wondering if it could be smarter. This may not be the time since this could get complicated (if you have a 5 dimensional DataArray should you be able to make an image out of that?). |
Regardless of whether or not this function is needed, the docstring is useful so I'll merge it. We can figure out how images are created at another time. |
Add missing docstring for the
to_image
function in thesatpy.writers.__init__
module.git diff origin/master -- "*py" | flake8 --diff