Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ABI Meso demo data case and clean up documentation #707

Merged
merged 2 commits into from Apr 9, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Apr 9, 2019

This adds another GOES-16 ABI case of multiple mesoscale sector over hurricane florence. I also cleaned up a few things that looked wrong or had warnings when generating sphinx documentation.

  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff
  • Fully documented

@djhoese djhoese self-assigned this Apr 9, 2019
@djhoese djhoese added this to the v0.14 milestone Apr 9, 2019
Includes a lot of changes to make fancier glob patterns possible on GCP
@djhoese djhoese marked this pull request as ready for review April 9, 2019 17:12
@djhoese djhoese changed the title [WIP] Add ABI Meso demo data case and clean up documentation Add ABI Meso demo data case and clean up documentation Apr 9, 2019
@djhoese
Copy link
Member Author

djhoese commented Apr 9, 2019

I'm not super happy with the way I had to do some of this stuff to get it to work. I don't know if there is a much better or easier way given the limitation on GCP's glob patterns and the way gcsfs works.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 79.829% when pulling 41867c4 on djhoese:feature-abi-meso-demo into 6cabadd on pytroll:master.

@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #707 into master will increase coverage by 0.07%.
The diff coverage is 98.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #707      +/-   ##
==========================================
+ Coverage   79.75%   79.82%   +0.07%     
==========================================
  Files         147      147              
  Lines       21300    21407     +107     
==========================================
+ Hits        16988    17089     +101     
- Misses       4312     4318       +6
Impacted Files Coverage Δ
satpy/tests/test_writers.py 97.81% <ø> (ø) ⬆️
satpy/readers/viirs_edr_active_fires.py 90% <ø> (ø) ⬆️
satpy/readers/viirs_sdr.py 85.02% <ø> (ø) ⬆️
satpy/demo/_google_cloud_platform.py 95.45% <100%> (ø)
satpy/tests/test_demo.py 96.07% <100%> (+2.23%) ⬆️
satpy/demo/__init__.py 95.12% <95.65%> (-0.34%) ⬇️
satpy/resample.py 87.08% <0%> (-0.38%) ⬇️
satpy/tests/test_scene.py 99.42% <0%> (-0.08%) ⬇️
satpy/scene.py 89.89% <0%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cabadd...41867c4. Read the comment docs.

@mraspaud
Copy link
Member

mraspaud commented Apr 9, 2019

It's not that bad!

@djhoese djhoese merged commit 2814f7f into pytroll:master Apr 9, 2019
@djhoese djhoese deleted the feature-abi-meso-demo branch April 9, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants