Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'seviri_0deg' and 'seviri_iodc' builtin areas (areas.yaml) not matching reader areas #708

Merged
merged 1 commit into from Apr 10, 2019

Conversation

sfinkens
Copy link
Member

@sfinkens sfinkens commented Apr 9, 2019

Make sure the extents of the seviri* area defs in areas.yaml are consistent with the extent of the area def returned by the seviri_l1b_hrit reader.

  • Tests passed

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 79.777% when pulling 44316c6 on sfinkens:align-seviri-areas-yaml into f422003 on pytroll:master.

@mraspaud mraspaud added the enhancement code enhancements, features, improvements label Apr 10, 2019
@mraspaud mraspaud added this to the v0.15 milestone Apr 10, 2019
@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #708 into master will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
+ Coverage   79.77%   80.04%   +0.26%     
==========================================
  Files         147      148       +1     
  Lines       21347    21923     +576     
==========================================
+ Hits        17030    17548     +518     
- Misses       4317     4375      +58
Impacted Files Coverage Δ
satpy/demo/__init__.py 94.54% <0%> (-0.91%) ⬇️
satpy/readers/viirs_edr_active_fires.py 89.55% <0%> (-0.45%) ⬇️
satpy/demo/_google_cloud_platform.py 95.45% <0%> (ø)
satpy/tests/compositor_tests/__init__.py 99.46% <0%> (+0.12%) ⬆️
satpy/tests/test_demo.py 96% <0%> (+2.15%) ⬆️
satpy/composites/__init__.py 70.92% <0%> (+5.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f422003...44316c6. Read the comment docs.

@mraspaud mraspaud merged commit ff45d3f into pytroll:master Apr 10, 2019
@sfinkens sfinkens deleted the align-seviri-areas-yaml branch April 10, 2019 11:48
@djhoese djhoese changed the title Align SEVIRI area defs from YAML and readers Fix 'seviri_0deg' and 'seviri_iodc' builtin areas (areas.yaml) not matching reader areas Apr 12, 2019
@djhoese djhoese added bug and removed enhancement code enhancements, features, improvements labels Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants